Merged
Conversation
Contributor
There was a problem hiding this comment.
this seems pretty expensive if the bitmap isn't roaring
are we planning on making roaring the default?
Contributor
Author
There was a problem hiding this comment.
I'm not planning on changing the default bitmap to roaring with this PR at least.
if anyone knows of a faster way to get a reverse bitmap iterator, please let me know
Contributor
There was a problem hiding this comment.
I don't think there's a better way for concise.
Also this code is just moved from lower down in the same file, it was added as part of the descending select patch. It should only get used for descending queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the proposal in #2742
This PR adds support for filtering without bitmap indexes, by adding a new filtering step during Cursor iteration in the QueryableIndexStorageAdapter.
The linked proposal contains details about the approach taken, with the exception that filter match result caching is not implemented (can be a later PR).
Benchmarks, using the benchmarks in #2875
Master:
Patch:
current results for reading 1,500,000 rows from a long column, no filters:
Benchmark that applies a single selector filter to a 750,000 row segment:
Master
Patch
Benchmark only applicable to this patch: