Kafka task minimum message time#3035
Merged
gianm merged 2 commits intoapache:masterfrom May 31, 2016
dclim:kafka-task-minimum-message-time
Merged
Kafka task minimum message time#3035gianm merged 2 commits intoapache:masterfrom dclim:kafka-task-minimum-message-time
gianm merged 2 commits intoapache:masterfrom
dclim:kafka-task-minimum-message-time
Conversation
Contributor
Author
|
@gianm @himanshug implemented as discussed in #3029; if you have time to review this in the near future we can include it in 0.9.1 - I think the changes are pretty straightforward (and yes I did end up including the minimumMessageTime as part of the sequenceName). |
Member
|
👍 , LGTM, only minor comments #3035 (comment) & #3035 (comment) |
Contributor
Author
|
@nishantmonu51 changes made, thanks for the review |
Contributor
There was a problem hiding this comment.
IIRC the comment on isTaskCurrent says what goes into this, and so should be updated
Contributor
|
👍 assuming nothing hinky is going on here https://github.com/druid-io/druid/pull/3035/files#r65221314 |
Contributor
Author
|
@gianm confirmed that this pull request contains zero hinkies. Comments added. |
Contributor
|
👍 after travis, thanks @dclim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KafkaIndexTask support for a minimumMessageTime parameter and changes to KafkaSupervisor to utilize this parameter. Allows users to specify a threshold for how old messages can be until they are dropped; this helps to prevent segment allocation conflicts when running a realtime and batch pipeline concurrently.
Resolves the issues discussed in #3029.