MetadataResource: Fix handling of includeDisabled.#3042
Conversation
|
👍 |
|
@gianm please remember to backport |
|
is there a test for this? |
| Collections2.transform( | ||
| druidDataSources, | ||
| new Function<DruidDataSource, String>() | ||
| // Cannot do both includeDisabled and full, let includeDisabled take priority |
There was a problem hiding this comment.
#3049 fixes it without any such restrictions. Although I am ok with this also if others do not have any problems with it.
There was a problem hiding this comment.
I see it will just return if includedDisabled is set..so never mind ignore the comment
|
@fjy why was this merged without having 2 👍 's? |
|
@gianm we change 0.9.0 to 0.9.1.1 and request the url "/druid/coordinator/v1/metadata/datasources" , return a empty list. thanks. |
|
@ChunXiaoLin this works for me on 0.9.1.1, are you expecting something other than an empty list? |
|
@gianm Sorry, i am not change mysql-metadata-storage version to 0.9.1.1, i have already been solved, thanks. |
|
@ChunXiaoLin cool, good to hear. |
5 participants
Regression from #2424,
/druid/coordinator/v1/metadata/datasources?includeDisabledno longer works for non-authenticated requests. The coordinator console needs this to list datasources that are eligible for re-enabling.