Skip to content

Fixups, clarifications to lookup docs.#3060

Merged
fjy merged 1 commit intoapache:masterfrom
gianm:qtl-docs
Jun 7, 2016
Merged

Fixups, clarifications to lookup docs.#3060
fjy merged 1 commit intoapache:masterfrom
gianm:qtl-docs

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Jun 2, 2016

No description provided.

@gianm gianm added this to the 0.9.1 milestone Jun 2, 2016
fjy
fjy reviewed Jun 2, 2016
View reviewed changes
Comment thread docs/content/toc.md Outdated
Copy link
Copy Markdown
Contributor

@fjy fjy Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically the joins section also links to lookups but i think this is cool

Copy link
Copy Markdown
Contributor Author

@gianm gianm Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vogievetsky mentioned it was difficult to find in there since he was just ctrl-F for "lookups"

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jun 2, 2016

👍

b-slim
b-slim reviewed Jun 2, 2016
View reviewed changes
Comment thread docs/content/development/extensions-core/lookups-cached-global.md Outdated
Copy link
Copy Markdown
Contributor

@b-slim b-slim Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add global ?

Copy link
Copy Markdown
Contributor Author

@gianm gianm Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Copy Markdown
Contributor Author

@gianm gianm Jun 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to "Globally Cached Lookups"

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Jun 2, 2016

@b-slim updated

@b-slim
Copy link
Copy Markdown
Contributor

b-slim commented Jun 2, 2016

👍

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Jun 2, 2016

@drcrallen does the diff look reasonable?

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Jun 2, 2016

travis stalled, I think.

Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.454 sec - in io.druid.granularity.QueryGranularityTest
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

@gianm gianm closed this Jun 2, 2016
@gianm gianm reopened this Jun 2, 2016
@gianm gianm mentioned this pull request Jun 3, 2016
Closed
@drcrallen
Copy link
Copy Markdown
Contributor

drcrallen commented Jun 6, 2016

Something clobbered this with merge conflicts, can you rebase please? 👍 otherwise

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Jun 7, 2016

@drcrallen fixed merge conflicts

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jun 7, 2016

👍

@fjy fjy merged commit 99ee3f4 into apache:master Jun 7, 2016
@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jun 7, 2016

@gianm remember to backport

gianm added a commit to gianm/druid that referenced this pull request Jun 7, 2016
@gianm
Fixups, clarifications to lookup docs. (apache#3060)
23440a0
@gianm gianm mentioned this pull request Jun 7, 2016
Merged
@gianm gianm modified the milestones: 0.9.2, 0.9.1 Sep 23, 2016
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Feb 25, 2022
@navis
apache#3060 LocalFirehose is missed some json properties
e136c7e
@gianm gianm deleted the qtl-docs branch September 23, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@gianm @fjy @b-slim @drcrallen