Retry for transient exceptions while doing cleanup for Hadoop Jobs#3177
Merged
drcrallen merged 3 commits intoapache:masterfrom Jun 23, 2016
Merged
Retry for transient exceptions while doing cleanup for Hadoop Jobs#3177drcrallen merged 3 commits intoapache:masterfrom
drcrallen merged 3 commits intoapache:masterfrom
Conversation
fixes apache#1828
Contributor
|
👍 |
Member
Author
|
travis failure with AnnouncerTest - https://travis-ci.org/druid-io/druid/jobs/139633994 |
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.io.retry.RetryPolicies; | ||
| import org.apache.hadoop.io.retry.RetryProxy; | ||
| import org.apache.hadoop.ipc.Server; |
Contributor
|
@nishantmonu51 can you make the title describe what the patch does? Also is there any test which would be appropriate to add for this? |
Contributor
|
@drcrallen I think difficult to test |
nishantmonu51
changed the title
| fs.delete(jobDir, true); | ||
| fs.delete(getJobClassPathDir(job.getJobName(), job.getWorkingDirectory()), true); | ||
| JobHelper.deleteWithRetry(fs, jobDir, true); | ||
| JobHelper.deleteWithRetry(fs, getJobClassPathDir(job.getJobName(), job.getWorkingDirectory()), true); |
Contributor
There was a problem hiding this comment.
Should this fire regardless of if the prior delete succeeds?
Contributor
|
👍 after travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1828