Closed
Conversation
acd01a6 to
92d6016
Compare
Contributor
|
@navis, this looks really useful! Haven't read everything yet, but initial comments:
|
Contributor
Author
|
b29addf to
a3a9211
Compare
a3a9211 to
af8b105
Compare
0e447db to
94e1d75
Compare
94e1d75 to
b312c2a
Compare
Contributor
Contributor
|
Closing as I believe this was covered in #4491 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We suffered some precision problems of metrics because currently it's allowed to be one of float or long type. This patch is for supporting double type metric in druid. I'm expecting BigDecimal type could be considered for next target.