Skip to content

WIP: optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2#3323

Closed
himanshug wants to merge 6 commits intoapache:masterfrom
himanshug:context_from_historicals
Closed

WIP: optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2#3323
himanshug wants to merge 6 commits intoapache:masterfrom
himanshug:context_from_historicals

Conversation

@himanshug
Copy link
Copy Markdown
Contributor

for talking to historicals and accumulate the response context.

DEPENDS ON #3319 and is reviewable after same is merged , creating PR for lookahead

enabled with "druid.broker.httpClient.useV3QueryUrl=true" in runtime.properties.

response context from broker would include response context from various historicals as...

{
"result": [.... ]
"context": {
.....
"historical1" : {...},
"historical2" : {....}
}

@himanshug himanshug force-pushed the context_from_historicals branch from c112eeb to 44e920d Compare August 4, 2016 14:58
@himanshug himanshug changed the title WIP: optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2 optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2 Aug 5, 2016
@himanshug himanshug changed the title optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2 WIP: optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2 Aug 5, 2016
@drcrallen drcrallen added this to the 0.9.3 milestone Aug 5, 2016
@drcrallen
Copy link
Copy Markdown
Contributor

Proposing as part of 0.9.3 for now as not to block 0.9.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose using a factory here with the two default implementations being a queryv2 and a queryv3 factory which can generate the proper return value.

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Nov 8, 2016

@himanshug is this still WIP?

@himanshug
Copy link
Copy Markdown
Contributor Author

himanshug commented Nov 9, 2016

@fjy it was ready but depends on #3319 so removing from 0.9.3 till that is merged. also i'm planning to make additional changes to #3319 which will require changes here too. see #3319 (comment)

@fjy fjy removed this from the 0.9.3 milestone Dec 9, 2016
@stale
Copy link
Copy Markdown

stale Bot commented Feb 28, 2019

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Feb 28, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Mar 7, 2019

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale Bot closed this Mar 7, 2019
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants