-
Notifications
You must be signed in to change notification settings - Fork 3.8k
First and Last Aggregator #3566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dbc1069
add first and last aggregator
acslk 759d902
add test and fix
acslk 4d96703
moving around
acslk 237b552
separate aggregator valueType
acslk 78bcfae
address PR comment
acslk 890c827
add finalize inner query and adjust v1 inner indexing
acslk 3c069a9
better test and fixes
acslk 481b526
java-util import fixes
jon-wei fa528cb
Merge remote-tracking branch 'upstream/master' into acslk-feature-fir…
jon-wei cc25586
PR comments
jon-wei 11e50b6
Add first/last aggs to ITWikipediaQueryTest
jon-wei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
common/src/main/java/io/druid/collections/SerializablePair.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. Metamarkets licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.druid.collections; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import io.druid.java.util.common.Pair; | ||
|
|
||
| public class SerializablePair<T1, T2> extends Pair<T1, T2> | ||
| { | ||
| @JsonCreator | ||
| public SerializablePair(@JsonProperty("lhs") T1 lhs, @JsonProperty("rhs") T2 rhs) | ||
| { | ||
| super(lhs, rhs); | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public T1 getLhs() | ||
| { | ||
| return lhs; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public T2 getRhs() | ||
| { | ||
| return rhs; | ||
| } | ||
| } |
51 changes: 51 additions & 0 deletions
51
common/src/test/java/io/druid/collections/SerializablePairTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. Metamarkets licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.druid.collections; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class SerializablePairTest | ||
| { | ||
| private static final ObjectMapper jsonMapper = new ObjectMapper(); | ||
|
|
||
| @Test | ||
| public void testBytesSerde() throws IOException | ||
| { | ||
| SerializablePair pair = new SerializablePair<>(5L, 9L); | ||
| byte[] bytes = jsonMapper.writeValueAsBytes(pair); | ||
| SerializablePair<Number, Number> deserializedPair = jsonMapper.readValue(bytes, SerializablePair.class); | ||
| Assert.assertEquals(pair.lhs, deserializedPair.lhs.longValue()); | ||
| Assert.assertEquals(pair.rhs, deserializedPair.rhs.longValue()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testStringSerde() throws IOException | ||
| { | ||
| SerializablePair pair = new SerializablePair<>(5L, 9L); | ||
| String str = jsonMapper.writeValueAsString(pair); | ||
| SerializablePair<Number, Number> deserializedPair = jsonMapper.readValue(str, SerializablePair.class); | ||
| Assert.assertEquals(pair.lhs, deserializedPair.lhs.longValue()); | ||
| Assert.assertEquals(pair.rhs, deserializedPair.rhs.longValue()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also document that if the rows are rolled up, the first/last value will be a the first/last value in druid row and not the raw data being ingested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added note about rollup behavior