Skip to content

Math expressions support for missing columns.#3630

Merged
fjy merged 1 commit intoapache:masterfrom
gianm:math-expressions-nullable
Nov 1, 2016
Merged

Math expressions support for missing columns.#3630
fjy merged 1 commit intoapache:masterfrom
gianm:math-expressions-nullable

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Oct 31, 2016

Also add SchemaEvolutionTest to help test this kind of thing.

Fixes #3627.

@gianm gianm added this to the 0.9.3 milestone Oct 31, 2016
@fjy
Copy link
Copy Markdown
Contributor

fjy commented Oct 31, 2016

👍

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Oct 31, 2016

@navis can you take a look?

Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
Copy link
Copy Markdown
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please add docs also for this.
👍, after docs are added.

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Nov 1, 2016

@nishantmonu51 I don't think this should block on docs. The original expressions PRs and a few follow ups have gone in without docs already, and behavior has been evolving. I prefer adding docs in a separate PR when we like the behavior.

@gianm
Copy link
Copy Markdown
Contributor Author

gianm commented Nov 1, 2016

Filed #3634 for that.

@fjy fjy merged commit 45940d6 into apache:master Nov 1, 2016
@gianm gianm deleted the math-expressions-nullable branch November 2, 2016 00:27
fundead pushed a commit to fundead/druid that referenced this pull request Dec 7, 2016
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
dgolitsyn pushed a commit to metamx/druid that referenced this pull request Feb 14, 2017
Also add SchemaEvolutionTest to help test this kind of thing.

Fixes apache#3627 and includes test for apache#3625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants