fix zero period in PeriodGranularity causing infinite loop then OOM

[kaijianding]

when construct PeriodGranularity with ZERO period like P0D, P0M, P0S... will cause infinite loop when calling gran.iterable(start, end), because the PeriodGranularity.next(long t) never move forward.
Finally, this issue will cause "out of heap space" error when makeCursors(...) and bring down the historical/realtime.

[gianm]

cool, thanks for the fix. Does DurationGranularity need something similar?

[gianm]

might as well toss this.period = Preconditions.checkNotNull(period, "period"); while we're here.

[gianm]

please add a test for this in QueryGranularityTest, ideally one with deserialization.

[kaijianding]

DurationGranularity doesn't need this check, the construct will throw zero divide error if millis=0

  public DurationGranularity(long millis, long origin)
  {
    this.length = millis;
    this.origin = origin % length;
  }

[gianm]

ha, cool :)

It'd be nice to have a check in DurationGranularity anyway, just to have a nicer error message.

[kaijianding]

checkNotNull and test added, @gianm

[gianm]

suggest Assert.fail() here just to make sure the exception is actually thrown. Or, use the @Rule ExpectedException (example in FileTaskLogsTest)

[kaijianding]

Modified.

[gianm]

👍 LGTM

[gianm]

thanks @kaijianding!

[nishantmonu51]

👍