Skip to content

Configurable HTTP compression.#3759

Merged
jon-wei merged 2 commits intoapache:masterfrom
gianm:http-compression-config
Dec 8, 2016
Merged

Configurable HTTP compression.#3759
jon-wei merged 2 commits intoapache:masterfrom
gianm:http-compression-config

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Dec 7, 2016

@gianm gianm added the Feature label Dec 7, 2016
@gianm gianm added this to the 0.9.3 milestone Dec 7, 2016
@gianm gianm assigned fjy and jon-wei Dec 7, 2016
@gianm gianm requested review from fjy and jon-wei December 7, 2016 23:40
@fjy
Copy link
Copy Markdown
Contributor

fjy commented Dec 7, 2016

👍

fjy
fjy reviewed Dec 7, 2016
View reviewed changes
Comment thread docs/content/configuration/broker.md Outdated
|`druid.server.http.maxIdleTime`|The Jetty max idle time for a connection.|PT5m|
|`druid.broker.http.numConnections`|Size of connection pool for the Broker to connect to historical and real-time nodes. If there are more queries than this number that all need to speak to the same node, then they will queue up.|20|
|`druid.broker.http.readTimeout`|The timeout for data reads.|PT15M|
|`druid.broker.http.compressionCodec`|Compression codec the Broker uses to communicate with historical and real-time nodes. May be "gzip" or "identity".|gzip|
Copy link
Copy Markdown
Contributor

@fjy fjy Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real-time processes

Copy link
Copy Markdown
Contributor Author

@gianm gianm Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Comment thread server/src/main/java/io/druid/guice/http/DruidHttpClientConfig.java

public class DruidHttpClientConfig
{
private final String DEFAULT_COMPRESSION_CODEC = "gzip";
Copy link
Copy Markdown
Contributor

@fjy fjy Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think uncompressed shuld be default

Copy link
Copy Markdown
Contributor Author

@gianm gianm Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to change the default in this PR.

@jon-wei
Copy link
Copy Markdown
Contributor

jon-wei commented Dec 8, 2016

👍

@jon-wei
Copy link
Copy Markdown
Contributor

jon-wei commented Dec 8, 2016

PR looks good, I do have a suggestion but it would involve releasing another version of http-client:

The String->CompressionCodec enum conversion could be done within http-client, e.g.:

    @JsonCreator
    public static CompressionCodec fromString(String name)
    {
      return valueOf(name.toUpperCase());
    }

Then DruidHttpClientConfig could use CompressionCodec enums directly instead of accepting String

@jon-wei jon-wei merged commit 943982b into apache:master Dec 8, 2016
dgolitsyn pushed a commit to metamx/druid that referenced this pull request Feb 14, 2017
@gianm @dgolitsyn
Configurable HTTP compression. (apache#3759)
a43c7da 
* Configurable HTTP compression.

* Call real-time nodes real-time processes in docs.
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Jan 10, 2020
@gianm @navis
backport of apache#3759 (Configurable HTTP compression)
9000dbd 
* Configurable HTTP compression.

* Call real-time nodes real-time processes in docs.
@gianm gianm deleted the http-compression-config branch September 23, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjy fjy fjy approved these changes

@jon-wei jon-wei Awaiting requested review from jon-wei

Assignees

No one assigned

Labels

Feature

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gianm @fjy @jon-wei