Require Java 8 and include some Java 8 dependencies.#3914
Require Java 8 and include some Java 8 dependencies.#3914gianm merged 4 commits intoapache:masterfrom
Conversation
- Upgrade Jetty to 9.3.16.v20170120. - Upgrade DataSketches to 0.8.4. - Bundle caffeine-cache by default. - Still target Java 7 when compiling base Druid classes.
|
Shall we also disable travis builds for jdk7? They, of course, do not pass after applying this patch. |
|
I tested this PR for hadoop compatibility with:
all running Java 8 on the hadoop cluster side, running a batch ingestion task on the wikiticker data, those all passed |
|
Thanks @jon-wei! In that case I'll take off the WIP tag and this is ready for review. |
gianm
changed the title
drcrallen
left a comment
drcrallen
left a comment
There was a problem hiding this comment.
Travis needs fixing, but other than that, can the changes here be limited to only what is required to get java 8 the default in the current codebase, and leave the "things that get better when we allow java8" in a separate PR?
| <groupId>com.yahoo.datasketches</groupId> | ||
| <artifactId>sketches-core</artifactId> | ||
| <version>0.4.1</version> | ||
| <version>0.8.4</version> |
There was a problem hiding this comment.
Is this really germane to java 8?
|
Discussed in dev sync. @gianm was going to update travis yaml before merge |
|
Removed jdk7 from travis.yml. |
|
👍 |
4 participants
Patch for #3746, #3745, #3710, #3595.
Our hadoop gauntlet tests don't pass with this, because they are running on Java 7. But hopefully they will pass after upgrading that test environment to Java 8. In the meantime I'm doing this as a WIP PR just so people can see the changes and try it in their own environment if they want.