Merged
Conversation
b-slim
reviewed
Feb 10, 2017
Contributor
There was a problem hiding this comment.
is this method still used ? if not we can remove it thought ?
Contributor
There was a problem hiding this comment.
or why not just renaming it close ?
Contributor
Author
There was a problem hiding this comment.
not used anywhere, Removing it.
* removed deleteOnExit from most of the tests/benchmarks/iopeon * Made IOpeon closable
Contributor
Author
|
Thanks @b-slim. Addressed comments. |
Contributor
|
👍 |
gianm
approved these changes
Feb 13, 2017
leventov
pushed a commit
to metamx/druid
that referenced
this pull request
Mar 3, 2017
* Less use of File.deleteOnExit() * removed deleteOnExit from most of the tests/benchmarks/iopeon * Made IOpeon closable * Formatting. * Revert DeterminePartitionsJobTest, remove cleanup method from IOPeon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3885
Removed deleteOnExit() from most of the classes except few(classes which heavily depend on this method).
-> ReplayableFirehose
-> SchemalessIndexTest
-> SpatialFilterBonusTest
-> SpatialFilterTest
-> DeterminePartitionsJobTest.java
Made IOpeon closable