SQL: Support for coercing to DECIMAL.#4028
Merged
jon-wei merged 1 commit intoapache:masterfrom Mar 13, 2017
Merged
Conversation
Useful for running queries that involve math of ints and floats, which Calcite types as decimal.
Contributor
|
SQL's DECIMAL type requires precision and scale, but it seems to be simply translated into Java's double type in this patch. Would you share your plan for supporting decimal type? |
Contributor
Author
|
I have no plan for that, this is coercion rather than real standard compliant support. I think it'd require changes to Druid core, not just the SQL layer, since it's not a type supported by Druid. |
Contributor
|
Right. The simplest solution would be adding a BigDecimal type to Druid and use it for SQL's decimal type. We can do or devise more efficient way later. The patch looks good to me. |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 13, 2017
Useful for running queries that involve math of ints and floats, which Calcite types as decimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for running queries that involve math of ints and floats, which
Calcite types as decimal. (see the test for an example)