Skip to content

SQL: Better error handling for HTTP API.#4053

Merged
fjy merged 3 commits intoapache:masterfrom
gianm:sql-http-errors
Mar 15, 2017
Merged

SQL: Better error handling for HTTP API.#4053
fjy merged 3 commits intoapache:masterfrom
gianm:sql-http-errors

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Mar 14, 2017

  • Report errors as friendly JSON rather than HTML.
  • Close result yielder if something goes wrong before starting to write the response, just like QueryResource.

Partially addresses #4047. Would like to include this in 0.10.0 since it improves error messages and is low risk, it only affects the new SQL feature.

@gianm gianm added this to the 0.10.0 milestone Mar 14, 2017
@gianm gianm requested review from fjy and jon-wei March 14, 2017 18:49
@jon-wei
Copy link
Copy Markdown
Contributor

jon-wei commented Mar 15, 2017

👍

1 similar comment
@fjy
Copy link
Copy Markdown
Contributor

fjy commented Mar 15, 2017

👍

@fjy fjy merged commit 403fbae into apache:master Mar 15, 2017
gianm added a commit to gianm/druid that referenced this pull request Mar 15, 2017
* SQL: Better error handling for HTTP API.

* Fix test.
fjy pushed a commit that referenced this pull request Mar 15, 2017
* SQL: Better error handling for HTTP API.

* Fix test.
@gianm gianm deleted the sql-http-errors branch September 23, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants