Merged
Conversation
Contributor
|
👍 |
Contributor
Author
|
Opinions on whether we should we include this in 0.10.0 too? |
|
Thank you for the quick turnaround @gianm! |
Contributor
|
Since this should fix 2 bugs 0.10.0 seems like a reasonable place |
drcrallen
approved these changes
Mar 15, 2017
Contributor
|
We will probably pull it into our deployment regardless. |
Contributor
Author
That's good, it derisks putting it into 0.10.0. I'll mark this for 0.10.0 then, since it's fixing bugs and you are planning to deploy it. |
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 15, 2017
fjy
pushed a commit
that referenced
this pull request
Mar 15, 2017
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 23, 2017
Reverts apache#4060, fixes apache#4095, unfixes apache#4056, apache#3837. Better the devil you know than the devil you don't, I always say. See also https://issues.apache.org/jira/browse/CURATOR-394.
Merged
gianm
added a commit
that referenced
this pull request
Mar 23, 2017
Reverts #4060, fixes #4095, unfixes #4056, #3837. Better the devil you know than the devil you don't, I always say. See also https://issues.apache.org/jira/browse/CURATOR-394.
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 23, 2017
Reverts apache#4060, fixes apache#4095, unfixes apache#4056, apache#3837. Better the devil you know than the devil you don't, I always say. See also https://issues.apache.org/jira/browse/CURATOR-394.
Contributor
Author
|
Reverted in #4103. |
fjy
pushed a commit
that referenced
this pull request
Mar 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4056, #3837.