Allow compilation as Java8 source and target (#3328)#4062
Merged
gianm merged 1 commit intoapache:0.10.0from Mar 15, 2017
Merged
Allow compilation as Java8 source and target (#3328)#4062gianm merged 1 commit intoapache:0.10.0from
gianm merged 1 commit intoapache:0.10.0from
Conversation
* Allow compilation as Java8 source and target for everything except API * Remove conditions in tests which assume that we may run with Java 7 * Update easymock to 3.4 * Make Animal Sniffer to check Java 1.8 usage; remove redundant druid-caffeine-cache configuration * Use try-with-resources in LargeColumnSupportedComplexColumnSerializerTest.testSanity() * Remove java7 special for druid-api
gianm
approved these changes
Mar 15, 2017
drcrallen
approved these changes
Mar 15, 2017
|
Does this mean that Caffeine could become the default in-memory cache since JDK8 is required? |
Contributor
|
I don't see why not, if it's always better than the default and doesn't bring in dependencies that would be difficult to deal with. |
Contributor
|
@ben-manes its worked so well for us I forget it isn't the default :-P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow compilation as Java8 source and target for everything except API
Remove conditions in tests which assume that we may run with Java 7
Update easymock to 3.4
Make Animal Sniffer to check Java 1.8 usage; remove redundant druid-caffeine-cache configuration
Use try-with-resources in LargeColumnSupportedComplexColumnSerializerTest.testSanity()
Remove java7 special for druid-api
Backport of #3328