Fix IngestSegmentFirehoseFactory#4069
Merged
leventov merged 1 commit intoapache:masterfrom Mar 17, 2017
Merged
Conversation
leventov
reviewed
Mar 16, 2017
Member
There was a problem hiding this comment.
Now it happens, should this comment be changed?
zhihuij
force-pushed
the
fix_ingestSegment
branch
from
5c74f2e to
bf2652b
Compare
Contributor
|
@leventov any other comments? |
leventov
approved these changes
Mar 17, 2017
jon-wei
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 24, 2017
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jun 13, 2017
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3608 and #3655 .
Pass the TaskToolbox of the task to the Firehose.