Fix some query cache key collisions.#4094
Merged
fjy merged 1 commit intoapache:masterfrom Mar 22, 2017
Merged
Conversation
The query caches generally store dimensions and aggregators positionally, so appendCacheablesIgnoringOrder could lead to incorrect results being pulled from the cache.
Contributor
|
👍 |
drcrallen
approved these changes
Mar 22, 2017
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 22, 2017
The query caches generally store dimensions and aggregators positionally, so appendCacheablesIgnoringOrder could lead to incorrect results being pulled from the cache.
gianm
added a commit
that referenced
this pull request
Mar 22, 2017
Contributor
|
Is this going to be added to the current 0.10.0-rc1 release as well or is there going to be a rc2? |
Contributor
Author
|
It'll be part of 0.10.0-rc2. |
Contributor
|
Any idea on when this will be released? |
Contributor
Author
|
It'll be when the list of blockers to release (https://github.com/druid-io/druid/milestone/21) is all resolved -- my guess is within a few days. If you want, you could build your own in the meantime, using the 0.10.0 branch. |
Contributor
Author
|
@erikdubbelboer RC2 is out now: http://druid.io/downloads.html |
Contributor
|
@gianm thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query caches generally store dimensions and aggregators positionally, so
appendCacheablesIgnoringOrder could lead to incorrect results being pulled
from the cache.
This was a regression introduced in #3899 while fixing #3719.