Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second patch for #4032.
Here are the highlights of the changes.
Queryto be able to have multiple data sources.JoinQueryannotateDistributionTargettoQueryToolChest.CachingClusteredClientcan figure out which data source is the target of query distribution when choosing nodes for query processing.DimensionSpecis changed to have an optional dataSource name field. Another option for this is to force the name ofDimensionSpecto always be prefixed with its dataSource name like'foo.dim1'. I think this is error-prone, and thus the former option is better.DimensionSpec, or extendDimensionSpecto cover metrics as well. (It's possible because it now supports long and double columns.)This change is