DatasourceInputSplit: Serialize with write instead of writeUTF.#4195
Merged
fjy merged 1 commit intoapache:masterfrom Apr 25, 2017
Merged
DatasourceInputSplit: Serialize with write instead of writeUTF.#4195fjy merged 1 commit intoapache:masterfrom
fjy merged 1 commit intoapache:masterfrom
Conversation
writeUTF has a limit of 64KB, making it difficult to write out splits that read a large number of descriptors for small segments.
Contributor
|
LGTM! |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
May 9, 2017
…he#4195) writeUTF has a limit of 64KB, making it difficult to write out splits that read a large number of descriptors for small segments.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 14, 2017
…he#4195) writeUTF has a limit of 64KB, making it difficult to write out splits that read a large number of descriptors for small segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeUTF has a limit of 64KB, making it difficult to write out splits
that read a large number of descriptors for small segments.