Implementing dropwizard emitter for druid (fixes #3927)#4196
Implementing dropwizard emitter for druid (fixes #3927)#4196rohitkochar wants to merge 2 commits intoapache:masterfrom
Conversation
|
@b-slim @himanshug |
|
Any update on this? I'm not super familiar with Dropwizard, so I may be conflating things, but I know Kafka uses Dropwizard's metrics library internally, and that's a pretty battle-tested piece of software. So it'd be nice to see this in Druid as well as it'd be very convenient to emit these metrics over JMX/StatsD, etc. |
|
Hi. Any update? Any schedule to review it? |
|
Sorry about the delayed review. @rohitkochar would you please update this PR by merging master? You also need to update the package name and the license of all new files to |
|
This would be great if it would allow emitting metrics in the various dropwizard supported formats. We're specifically looking for prometheus exporting, which can be hooked up through the jmx exporter with https://github.com/prometheus/jmx_exporter |
|
@rohitkochar Thanks for the PR. We are also looking for enabling exposing druid metrics via JMX. |
|
FYI, I am working on refactoring this patch for latest druid. Will start by cherry-picking @rohitkochar commit so that he gets credit for the work done. |
|
Closing in favor of #7363 |
Corresponding issues are
#3927
#1996