Skip to content

Implementing dropwizard emitter for druid (fixes #3927)#4196

Closed
rohitkochar wants to merge 2 commits intoapache:masterfrom
rohitkochar:dropwizard-emitter
Closed

Implementing dropwizard emitter for druid (fixes #3927)#4196
rohitkochar wants to merge 2 commits intoapache:masterfrom
rohitkochar:dropwizard-emitter

Conversation

@rohitkochar
Copy link
Copy Markdown
Contributor

Corresponding issues are
#3927
#1996

@rohitkochar
Copy link
Copy Markdown
Contributor Author

@b-slim @himanshug
Requesting you to review this pull request.
The code structure is based on the graphite-emitter contributed by @b-slim

@leventov leventov changed the title Implementing dropwizard emitter for druid (https://github.com/druid-io/druid/issues/3927) Implementing dropwizard emitter for druid (fixes #3927) Apr 24, 2017
@jeffwidman
Copy link
Copy Markdown

jeffwidman commented Nov 10, 2017

Any update on this?

I'm not super familiar with Dropwizard, so I may be conflating things, but I know Kafka uses Dropwizard's metrics library internally, and that's a pretty battle-tested piece of software. So it'd be nice to see this in Druid as well as it'd be very convenient to emit these metrics over JMX/StatsD, etc.

@dkhwangbo
Copy link
Copy Markdown
Contributor

Hi. Any update? Any schedule to review it?

@jihoonson
Copy link
Copy Markdown
Contributor

Sorry about the delayed review. @rohitkochar would you please update this PR by merging master? You also need to update the package name and the license of all new files to org.apache.druid and the Apache license, respectively.

@mlubavin-vg
Copy link
Copy Markdown

This would be great if it would allow emitting metrics in the various dropwizard supported formats. We're specifically looking for prometheus exporting, which can be hooked up through the jmx exporter with https://github.com/prometheus/jmx_exporter

@nishantmonu51
Copy link
Copy Markdown
Member

@rohitkochar Thanks for the PR. We are also looking for enabling exposing druid metrics via JMX.
@rohitkochar, are you still planning to work on this PR ?

@nishantmonu51
Copy link
Copy Markdown
Member

FYI, I am working on refactoring this patch for latest druid. Will start by cherry-picking @rohitkochar commit so that he gets credit for the work done.

@nishantmonu51
Copy link
Copy Markdown
Member

Closing in favor of #7363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants