DirectDruidClient: Fix division by zero.#4206
Merged
gianm merged 2 commits intoapache:masterfrom Apr 25, 2017
Merged
Conversation
Introduced in apache#3954 when some floating math was changed to integer math. This patch restores the old math.
Contributor
|
👍 |
jihoonson
approved these changes
Apr 25, 2017
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
Looks good to me, but it would be great if you add a comment for this problem.
| TimeUnit.NANOSECONDS.toMillis(nodeTimeNs), | ||
| byteCount.get() / TimeUnit.NANOSECONDS.toSeconds(nodeTimeNs) | ||
| nodeTimeMs, | ||
| byteCount.get() / (0.001 * nodeTimeMs) |
Contributor
There was a problem hiding this comment.
It would be better to leave a comment here.
jon-wei
approved these changes
Apr 25, 2017
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #3954 when some floating math was changed to
integer math. This patch restores the old math.