fix timeout check bug in DirectDruidClient#4287
Merged
fjy merged 1 commit intoapache:masterfrom May 17, 2017
Merged
Conversation
drcrallen
approved these changes
May 17, 2017
Contributor
drcrallen
left a comment
drcrallen
left a comment
There was a problem hiding this comment.
Is this covered by unit tests?
Contributor
Author
|
@drcrallen there are tests with mocks which did not cover this specific change. i tried that today but looks like it would need some refactoring in there to make it testable where in the response handler could be exercised. |
Member
|
@himanshug are you trying to add unit test or is this mergeable ? |
Contributor
|
Does this solve #1415 ? |
Contributor
Author
|
@drcrallen this (and #4229 ) solve #1415 partially , timeout handling probably needs to be handled in many different places to fully solve #1415 . this should solve it at broker for queries which are processed fully in streams. @pjain1 no, not in this pr at least. this is mergeable. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression from #4229