-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add support for HttpFirehose #4297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
server/src/main/java/io/druid/segment/realtime/firehose/HttpFirehoseFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. Metamarkets licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.druid.segment.realtime.firehose; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import io.druid.data.input.impl.PrefetchableTextFilesFirehoseFactory; | ||
| import io.druid.java.util.common.CompressionUtils; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.net.URI; | ||
| import java.util.Collection; | ||
| import java.util.List; | ||
|
|
||
| public class HttpFirehoseFactory extends PrefetchableTextFilesFirehoseFactory<URI> | ||
| { | ||
| private final List<URI> uris; | ||
|
|
||
| @JsonCreator | ||
| public HttpFirehoseFactory( | ||
| @JsonProperty("uris") List<URI> uris, | ||
| @JsonProperty("maxCacheCapacityBytes") Long maxCacheCapacityBytes, | ||
| @JsonProperty("maxFetchCapacityBytes") Long maxFetchCapacityBytes, | ||
| @JsonProperty("prefetchTriggerBytes") Long prefetchTriggerBytes, | ||
| @JsonProperty("fetchTimeout") Long fetchTimeout, | ||
| @JsonProperty("maxFetchRetry") Integer maxFetchRetry | ||
| ) | ||
| { | ||
| super(maxCacheCapacityBytes, maxFetchCapacityBytes, prefetchTriggerBytes, fetchTimeout, maxFetchRetry); | ||
| this.uris = uris; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public List<URI> getUris() | ||
| { | ||
| return uris; | ||
| } | ||
|
|
||
| @Override | ||
| protected Collection<URI> initObjects() | ||
| { | ||
| return uris; | ||
| } | ||
|
|
||
| @Override | ||
| protected InputStream openObjectStream(URI object) throws IOException | ||
| { | ||
| return object.toURL().openConnection().getInputStream(); | ||
| } | ||
|
|
||
| @Override | ||
| protected InputStream wrapObjectStream(URI object, InputStream stream) throws IOException | ||
| { | ||
| return object.getPath().endsWith(".gz") ? CompressionUtils.gzipInputStream(stream) : stream; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will there be duplication in the case when this returns an InputStream ... which is partially read and then there is a temporary network glitch and consequently an IOException. parent class does the retry (which starts reading data from beginning again) and ends up introducing duplicates ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine.
1.1)
PrefetchableTextFilesFirehosecan fetch http objects in background. Whennext()is called, it first checks that there are already fetched files in local storage. If exists, it simply chooses a fetched file and returns aLineIteratorfor that file.1.2) If there is no fetched files in local storage but some objects are still remained to be read,
PrefetchableTextFilesFirehosefetches one of objects in background immediately. If an IOException occurs while downloading the object, it retries up to the maximum retry count. Finally,PrefetchableTextFilesFirehosereturns aLineIteratoronly when the download operation is successfully finished.PrefetchableTextFilesFirehosereturns a LineIterator which directly reads the stream opened byopenObjectStream(). If there is an IOException, it will throw it and the read will fail.Does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I see from
PrefetchTextFilesFirehoseFactory.download(..)that whole contents are downloaded irrespective ofcache/prefetch capacity bytes, which is fair to keep implementation simpler . it will be nice to document it in some way though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll add a document about the behavior of
PrefetchableTextFilesFirehosesomewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the behavior of
PrefetchableTextFilesFirehoseto its java doc.