Skip to content

Workaround for non-thread-safe use of CardinalityAggregator. #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
May 23, 2017
Merged

Workaround for non-thread-safe use of CardinalityAggregator. #4304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion processing/src/main/java/io/druid/query/aggregation/cardinality/CardinalityAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ public void reset()
@Override
public Object get()
{
return collector;
// Workaround for non-thread-safe use of HyperLogLogCollector.
// OnheapIncrementalIndex has a penchant for calling "aggregate" and "get" simultaneously.
return HyperLogLogCollector.makeCollectorSharingStorage(collector);
}

@Override
Expand Down
3 changes: 2 additions & 1 deletion processing/src/main/java/io/druid/query/aggregation/hyperloglog/HyperUniquesAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public void reset()
@Override
public Object get()
{
// Workaround for OnheapIncrementalIndex's penchant for calling "aggregate" and "get" simultaneously.
// Workaround for non-thread-safe use of HyperLogLogCollector.
// OnheapIncrementalIndex has a penchant for calling "aggregate" and "get" simultaneously.
return HyperLogLogCollector.makeCollectorSharingStorage(collector);
}

Expand Down