Make the Coordinator Cost Balancer thread naming human friendly#4354
Merged
leventov merged 2 commits intoapache:masterfrom Jun 6, 2017
Merged
Make the Coordinator Cost Balancer thread naming human friendly#4354leventov merged 2 commits intoapache:masterfrom
leventov merged 2 commits intoapache:masterfrom
Conversation
leventov
approved these changes
Jun 2, 2017
Contributor
Author
|
@leventov is there a way to get teamcity results be visible without a login? |
…ingCoorinatorCost
Member
|
@drcrallen the reason of the failure is that you based your post-#4348 PR on a pre-#4348 commit. |
Member
|
@drcrallen there is a link "Log in as guest" on the authorization page. It will forward you to results without any extra steps. |
Contributor
|
@drcrallen @leventov does this absolutely need to be in 0.10.1? |
Member
|
@fjy I think no, but I don't see problems with merging it, since there are still several outstanding PRs and issues in 0.10.1 which are quite far from being merged/resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This thread pool has an old history. This PR is to bring the naming up to scruff with current general ways of naming things.
This has a side-effect of making the threads daemon threads, but the block which defines the executor service has a finally which calls
shutdownNow, so it should be ok.