Uncompress streams without having to download to tmp first#4364
Merged
fjy merged 2 commits intoapache:masterfrom Jun 9, 2017
Merged
Uncompress streams without having to download to tmp first#4364fjy merged 2 commits intoapache:masterfrom
fjy merged 2 commits intoapache:masterfrom
Conversation
b-slim
reviewed
Jun 5, 2017
| @@ -0,0 +1,210 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
Author
There was a problem hiding this comment.
Not required, removing it
Contributor
|
@niketh how about the HDFS Puller ? also curious what is the main driver is it perf ? stability ? misc ? |
Contributor
Author
Contributor
|
ok looks like it is a performance improvement plus making pullers more uniform. 👍 |
Contributor
|
👍 |
drcrallen
reviewed
Jun 9, 2017
Contributor
drcrallen
left a comment
drcrallen
left a comment
There was a problem hiding this comment.
If I recall correctly the download to tmp first allows mmap of the zip file and decompression, and knowing all the components and their size. This does things on heap as they come in. Should be ok for most use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncompress streams without having to download to tmp first