Merged
Conversation
Contributor
|
👍 |
leventov
reviewed
Jun 6, 2017
| @@ -88,7 +93,7 @@ | |||
| <properties> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <jmh.version>1.17.2</jmh.version> | |||
Member
There was a problem hiding this comment.
Could you please also update JMH?
| private QueryableIndex index; | ||
| private JavaScriptAggregatorFactory javaScriptAggregatorFactory; | ||
| private DoubleSumAggregatorFactory expressionAggregatorFactory; | ||
| private ByteBuffer aggregationBuffer = ByteBuffer.allocate(Doubles.BYTES); |
Member
There was a problem hiding this comment.
Double.BYTES exists from Java 8
| import java.util.function.Function; | ||
|
|
||
| @State(Scope.Benchmark) | ||
| @Fork(jvmArgsPrepend = "-server", value = 1) |
Member
There was a problem hiding this comment.
Since Java 8, -server is the default on 64-bit systems: http://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html
Contributor
Author
There was a problem hiding this comment.
Removed from here and other similar benchmark files.
| } | ||
|
|
||
| @Benchmark | ||
| @BenchmarkMode(Mode.AverageTime) |
Member
There was a problem hiding this comment.
Since all benchmarks in the class use the same mode and time unit, could be moved to the class header
Contributor
Author
|
@leventov Addressed your comments. |
leventov
approved these changes
Jun 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The results in master, for the curious:
I hope we can use this in the future to guide optimization of the expression subsystem. It does a number of things sub-optimally right now.