Skip to content

SQL: More forgiving Avatica server.#4368

Merged
fjy merged 2 commits intoapache:masterfrom
gianm:avatica-more-forgiving
Jun 6, 2017
Merged

SQL: More forgiving Avatica server.#4368
fjy merged 2 commits intoapache:masterfrom
gianm:avatica-more-forgiving

Conversation

@gianm
Copy link
Copy Markdown
Contributor

@gianm gianm commented Jun 6, 2017

Some changes to make life easier for users that aren't being completely scrupulous
with closing connections and statements. And also, for dealing with the realities that
sometimes clients crash and we need to clean up stale connections promptly or else
the server becomes unresponsive to new ones.

  • Automatically close statements that are fully iterated or that have
    errors, to prevent dangling statements from causing clients to hit
    open statement limits.
  • Empower client auto-reconnects by throwing NoSuchConnectionException
    when appropriate.
  • Try to close empty connections when we hit the open connection limit,
    rather than failing the newly opened connection. Client
    auto-reconnections mean this shouldn't cause problems in practice.
  • Improve concurrency of the server by making "connections" a
    concurrent map.
  • Lower default connection timeout to PT5M from PT30M.

- Automatically close statements that are fully iterated or that have
  errors, to prevent dangling statements from causing clients to hit
  open statement limits.
- Empower client auto-reconnects by throwing NoSuchConnectionException
  when appropriate.
- Try to close empty connections when we hit the open connection limit,
  rather than failing the newly opened connection. Client
  auto-reconnections mean this shouldn't cause problems in practice.
- Improve concurrency of the server by making "connections" a
  concurrent map.
- Lower default connection timeout to PT5M from PT30M.
@fjy
Copy link
Copy Markdown
Contributor

fjy commented Jun 6, 2017

👍

@fjy fjy merged commit 67b162a into apache:master Jun 6, 2017
@fjy fjy added this to the 0.10.1 milestone Jun 6, 2017
@gianm gianm deleted the avatica-more-forgiving branch June 7, 2017 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants