SQL: More forgiving Avatica server.#4368
Merged
fjy merged 2 commits intoapache:masterfrom Jun 6, 2017
Merged
Conversation
- Automatically close statements that are fully iterated or that have errors, to prevent dangling statements from causing clients to hit open statement limits. - Empower client auto-reconnects by throwing NoSuchConnectionException when appropriate. - Try to close empty connections when we hit the open connection limit, rather than failing the newly opened connection. Client auto-reconnections mean this shouldn't cause problems in practice. - Improve concurrency of the server by making "connections" a concurrent map. - Lower default connection timeout to PT5M from PT30M.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to make life easier for users that aren't being completely scrupulous
with closing connections and statements. And also, for dealing with the realities that
sometimes clients crash and we need to clean up stale connections promptly or else
the server becomes unresponsive to new ones.
errors, to prevent dangling statements from causing clients to hit
open statement limits.
when appropriate.
rather than failing the newly opened connection. Client
auto-reconnections mean this shouldn't cause problems in practice.
concurrent map.