Add legacy constructor to CsvParseSpec and DelimitedParseSpec for backward compatibility#4388
Merged
jon-wei merged 3 commits intoapache:masterfrom Jun 9, 2017
Merged
Conversation
jon-wei
reviewed
Jun 9, 2017
|
|
||
| @Deprecated | ||
| public CSVParseSpec( | ||
| @JsonProperty("timestampSpec") TimestampSpec timestampSpec, |
Contributor
There was a problem hiding this comment.
I don't think you need the @JsonProperty annotations here since only the main constructor is @JsonCreator, this legacy constructor would only be used when directly instantiating
Contributor
Author
There was a problem hiding this comment.
You're correct. Removed them.
Member
|
If so maybe also need to add constructors for other classes altered in #4254, e. g. DelimitedParseSpec |
Contributor
Author
|
@leventov thanks. I added it too. CSVFlatDataParser and TSVFlatDataParser in extensions-core are changed as well. Should they also need to be backward compatible? |
Member
|
@jihoonson IMO not needed |
leventov
approved these changes
Jun 9, 2017
jihoonson
changed the title
jon-wei
approved these changes
Jun 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some external users are using this API, so the legacy constructor is needed (#4254 (comment)).
This change is