Queries: Restore old prepareAggregations method.#4432
Merged
b-slim merged 1 commit intoapache:masterfrom Jun 21, 2017
Merged
Conversation
For backwards compatibility, post-apache#4394.
Member
|
@gianm I think 0.10.2 is going to be 0.11.0, so this PR should probably just not go to master, only to 0.10.1 |
Contributor
Author
|
I don't think there's an issue in 0.10.1, since #4394 wasn't included there. I'm still ok with this patch in master, it makes life a little easier for people upgrading, and that's always good. (just because we can break an API doesn't mean we should) |
Contributor
Author
|
Oops, 0.10.1 did include #4394, I was looking at 0.10.0. Point about master still stands though. If we merge it to master I can do a backport to 0.10.1 after that. Or if we decide not to merge to master it could go directly to 0.10.1. |
Contributor
|
+1 for going directly to 0.10.1 |
leventov
approved these changes
Jun 21, 2017
gianm
added a commit
to gianm/druid
that referenced
this pull request
Jun 21, 2017
For backwards compatibility, post-apache#4394.
gianm
added a commit
that referenced
this pull request
Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For backwards compatibility, post-#4394.