-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add @ExtensionPoint and @PublicApi annotations. #4433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
202c51e
3fbf4bd
bea326b
100ca4d
06facda
eed9e1f
ce76f9d
9a300b2
be8fde6
5070451
4aa3045
3878d1a
73341a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,16 +22,18 @@ | |
| import com.google.inject.Binder; | ||
| import com.google.inject.Key; | ||
| import com.google.inject.multibindings.MapBinder; | ||
| import io.druid.guice.annotations.PublicApi; | ||
| import io.druid.segment.loading.DataSegmentArchiver; | ||
| import io.druid.segment.loading.DataSegmentFinder; | ||
| import io.druid.segment.loading.DataSegmentMover; | ||
| import io.druid.segment.loading.DataSegmentKiller; | ||
| import io.druid.segment.loading.DataSegmentMover; | ||
| import io.druid.segment.loading.DataSegmentPuller; | ||
| import io.druid.segment.loading.DataSegmentPusher; | ||
| import io.druid.tasklogs.TaskLogs; | ||
|
|
||
| /** | ||
| */ | ||
| @PublicApi | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually its more of an utility class and shouldn't necessarily be directly used in custom user extension (it can be used in out-of-the-box extensions) and those should really just use MapBinder.xxx .
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was thinking it would be nice to make a utility like this public. I don't feel super strongly though. |
||
| public class Binders | ||
| { | ||
| public static MapBinder<String, DataSegmentPuller> dataSegmentPullerBinder(Binder binder) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this public api so that users can use this class in their java clients to construct druid queries ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because ParseSpec is an extension point, and it returns DimensionsSpec, which is constructed using DimensionSchema. So implementors of custom ParseSpecs might need to use this class.