exclude aws-java-sdk from hadoop-aws dep in hdfs-storage module#4437
Merged
leventov merged 2 commits intoapache:masterfrom Jun 22, 2017
Merged
exclude aws-java-sdk from hadoop-aws dep in hdfs-storage module#4437leventov merged 2 commits intoapache:masterfrom
leventov merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
👍 after tests. Thanks @himanshug |
b-slim
approved these changes
Jun 21, 2017
leventov
requested changes
Jun 21, 2017
| </dependency> | ||
| <dependency> | ||
| <groupId>com.amazonaws</groupId> | ||
| <artifactId>aws-java-sdk-s3</artifactId> |
Member
There was a problem hiding this comment.
Please add the same list of exclusions as above for aws-java-sdk-ec2:
<exclusions>
<exclusion>
<groupId>javax.mail</groupId>
<artifactId>mail</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</exclusion>
<exclusion>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</exclusion>
</exclusions>| @@ -189,7 +190,7 @@ | |||
| <artifactId>aws-java-sdk-ec2</artifactId> | |||
| <!-- Cannot update to AWS SDK 1.11+ because of Jackson incompatibility. | |||
Member
There was a problem hiding this comment.
Please move this comment to where aws.sdk.version is declared, line 78.
leventov
approved these changes
Jun 21, 2017
Member
|
Seems that integration tests failed. |
Member
|
@himanshug could you restart build from travis page? it's 1 more click for you, but OTOH it doesn't create email notifications for PR subscribers |
Contributor
|
@himanshug can you backport this please ? |
fjy
pushed a commit
that referenced
this pull request
Jun 23, 2017
…torage module (#4451) * exclude aws-java-sdk from hdfs-storage module * address review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead make it use
aws-java-sdk-s3.Fix for the issue discussed in #4313 (comment) about aws always requiring credentials directory. i verified the this patch to ensure that said issue is fixed.