Fix a bug of CSV/TSV parsers when extracting columns from header#4443
Merged
fjy merged 3 commits intoapache:masterfrom Jun 23, 2017
Merged
Fix a bug of CSV/TSV parsers when extracting columns from header#4443fjy merged 3 commits intoapache:masterfrom
fjy merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Hmm, travis is getting weird more. I ran unit tests and integration tests in my local machine 5 times, and every test was passed. |
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Jun 23, 2017
…che#4443) * Reset fieldNames whenever a new file begins * Fix test failure * Fix test failure
leventov
pushed a commit
that referenced
this pull request
Jun 26, 2017
…) (#4459) * Reset fieldNames whenever a new file begins * Fix test failure * Fix test failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since each file can have different columns,
fieldNamesof CSV/TSV parsers should be reset when a new file begins.This change is