Skip to content

Make KafkaLookupExtractorFactoryTest fast#4466

Merged
leventov merged 3 commits intoapache:masterfrom
jihoonson:fast-klef-test
Jun 26, 2017
Merged

Make KafkaLookupExtractorFactoryTest fast#4466
leventov merged 3 commits intoapache:masterfrom
jihoonson:fast-klef-test

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson commented Jun 24, 2017

Fix #4402 (comment).


This change is Reviewable

@jihoonson jihoonson closed this Jun 24, 2017
@jihoonson jihoonson reopened this Jun 24, 2017
};
}

private static class ByteArray
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Bytes.asList()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Member

@pjain1 pjain1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leventov leventov merged commit 5fec619 into apache:master Jun 26, 2017
jon-wei pushed a commit to jon-wei/druid that referenced this pull request Jul 19, 2017
* Make KafkaLookupExtractorFactoryTest fast

* Use list

* Use Bytes
@jon-wei jon-wei added this to the 0.10.1 milestone Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants