Skip to content

Respect reportParseExceptions option in IndexTask.determineShardSpecs()#4467

Merged
gianm merged 2 commits intoapache:masterfrom
jihoonson:ignore-parse-exception
Jun 27, 2017
Merged

Respect reportParseExceptions option in IndexTask.determineShardSpecs()#4467
gianm merged 2 commits intoapache:masterfrom
jihoonson:ignore-parse-exception

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

@jihoonson jihoonson commented Jun 26, 2017

Fixes a bug that reportParseExceptions is not respected in IndexTask.determineShardSpecs().


This change is Reviewable

@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@jihoonson jihoonson closed this Jun 26, 2017
@jihoonson jihoonson reopened this Jun 26, 2017
@gianm gianm added the Bug label Jun 26, 2017
@gianm gianm added this to the 0.10.1 milestone Jun 26, 2017
@gianm
Copy link
Copy Markdown
Contributor

gianm commented Jun 26, 2017

Marked 0.10.1 since this looks like a regression to me.

log.warn("Unable to find a matching interval for [%,d] events", thrownAway);
}
if (unparseable > 0) {
log.warn("Unable to parse [%d,] events", unparseable);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean [%,d] here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

@dclim
Copy link
Copy Markdown
Contributor

dclim commented Jun 26, 2017

👍 after minor comment resolved

@gianm gianm merged commit e3c13c2 into apache:master Jun 27, 2017
gianm pushed a commit to gianm/druid that referenced this pull request Jun 27, 2017
…() (apache#4467)

* Respect reportParseExceptions option in IndexTask.determineShardSpecs()

* Fix typo
fjy pushed a commit that referenced this pull request Jun 28, 2017
…() (#4467) (#4473)

* Respect reportParseExceptions option in IndexTask.determineShardSpecs()

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants