[Backport] More fine-grained DI for management node types. Don't allocate processing resources on Router#4478
Merged
fjy merged 1 commit intoapache:0.10.1from Jun 28, 2017
Conversation
…sing resources on Router (apache#4429) * Remove DruidProcessingModule, QueryableModule and QueryRunnerFactoryModule from DI for coordinator, overlord, middle-manager. Add RouterDruidProcessing not to allocate processing resources on router * Fix examples * Fixes * Revert Peon configs and add comments * Remove qualifier
Member
|
Note that this change led to a usability problem for us, when some extension includes some query-related and non-query-related stuff, and loaded on all types of nodes, and with this change that approach fails on the node types which don't include query-stuff anymore, like coordinator, because certain things couldn't be injected. The solution is #4438, so I changed it's milestone to 0.10.1 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4429 to 0.10.1.