Fix GroupBy type cast when ChainedExecutionQueryRunner merges results#4488
Merged
gianm merged 4 commits intoapache:masterfrom Jul 1, 2017
Merged
Fix GroupBy type cast when ChainedExecutionQueryRunner merges results#4488gianm merged 4 commits intoapache:masterfrom
gianm merged 4 commits intoapache:masterfrom
Conversation
leventov
reviewed
Jun 29, 2017
| ); | ||
| } | ||
|
|
||
| // Convert dimension types to specified output types |
Member
There was a problem hiding this comment.
Please make this conversion a method
Member
There was a problem hiding this comment.
Now this comment almost exactly repeats the method name so not needed
Contributor
Author
There was a problem hiding this comment.
removed the unnecessary comment
leventov
reviewed
Jun 30, 2017
| private static void convertRowTypesToOutputTypes(List<DimensionSpec> dimensionSpecs, Map<String, Object> rowMap) | ||
| { | ||
| for (DimensionSpec dimSpec : dimensionSpecs) { | ||
| Object baseVal = rowMap.get(dimSpec.getOutputName()); |
Contributor
Author
There was a problem hiding this comment.
I decided to keep it as-is, the function for compute(...) would need to lookup the outputType associated with the dimension name key.
That info is only kept in the DimensionSpecs list from the query in that context, so it would have to scan the list for every key or keep some other mapping structure of dimName->outputType around
Member
There was a problem hiding this comment.
Hm, why?
for (DimensionSpec dimSpec : dimensionSpecs) {
ValueType outputType = dimSpec.getOutputType();
rawMap.compute(dimSpec.getOutputName(), (name, baseVal) -> {
switch (outputType) {
case STRING:
return baseVal == null ? "" : baseVal.toString();
...
}
});
}
gianm
approved these changes
Jun 30, 2017
jon-wei
force-pushed
the
groupby_type_merge_fix
branch
from
c3ce20b to
3ed1057
Compare
jon-wei
force-pushed
the
groupby_type_merge_fix
branch
from
c1daa42 to
9dfd18d
Compare
leventov
approved these changes
Jun 30, 2017
| (dimName, baseVal) -> { | ||
| switch (outputType) { | ||
| case STRING: | ||
| baseVal = baseVal == null ? "" : baseVal.toString(); |
Member
There was a problem hiding this comment.
[Minor] Could return from switch, without reassigning baseVal and break
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Jul 1, 2017
…apache#4488) * Fix GroupBy type cast error when ChainedExecutionQueryRunner merges multiple runners * Move conversion step to separate method * Remove unnecessary comment * Use compute to update map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the "outputType" parameter of DimensionSpec to change the type of a dimension, a ClassCastException would occur when the ChainedExecutionQueryRunner merges results from multiple query runners:
The unit test provides an example that would trigger the error.
This patch adds a type conversion step to results generated by GroupByEngineV2 before they are merged by the ChainedExecutionQueryRunner.