Fix a bug in DruidCluster.getAllServers()#4500
Merged
gianm merged 2 commits intoapache:masterfrom Jul 5, 2017
Merged
Conversation
leventov
reviewed
Jul 4, 2017
| return historicals.values().stream() | ||
| .flatMap(Collection::stream) | ||
| .collect(() -> realtimes, Set::add, Set::addAll); | ||
| final List<ServerHolder> allServers = historicals.values().stream() |
Member
There was a problem hiding this comment.
Suggested more old-style to avoid list reallocation:
int historicalServers = historicals.values().stream().mapToInt(Collection::size).sum();
int allServers = historicalServers + realtimes.size();
List<ServerHolder> result = new ArrayList<>(allServers);
historicals.values().forEach(tierServers -> result.addAll(tierServers));
result.addAll(realtimes);
return result;
Member
There was a problem hiding this comment.
Or could use ImmutableList.builder
Contributor
Author
There was a problem hiding this comment.
I like the former one because DruidCluster is effectively used as immutable once all cluster nodes are added.
Member
There was a problem hiding this comment.
@jihoonson could it be turned into a proper immutable then, to avoid bugs? Also getAllServers() could be cached.
Contributor
Author
There was a problem hiding this comment.
Ah, I think it would be ok. Actually DruidCluster is a snapshot of the ServerInventoryView. DruidCoordinator builds a new DruidCluster at each run and this snapshot is used by subsequent DruidCoordinatorHelpers in the same run.
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Jul 5, 2017
* Fix a bug in getAllServers * Change to old style
leventov
pushed a commit
that referenced
this pull request
Jul 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
realtimesis accidentally changed after calling getAllServers(), but must not.This change is