Skip to content

enforce compile scope#4524

Merged
gianm merged 1 commit intoapache:masterfrom
b-slim:fix_compile_scope
Jul 11, 2017
Merged

enforce compile scope#4524
gianm merged 1 commit intoapache:masterfrom
b-slim:fix_compile_scope

Conversation

@b-slim
Copy link
Copy Markdown
Contributor

@b-slim b-slim commented Jul 10, 2017

For some bogus reason when compiling with a different (in-house) hadoop version the scope of this dependency becomes runtime which fails the build.
This PR enforce the default compile scope.

@b-slim b-slim added this to the 0.10.1 milestone Jul 10, 2017
@b-slim b-slim requested a review from nishantmonu51 July 10, 2017 19:24
Copy link
Copy Markdown
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gianm gianm merged commit a603c4b into apache:master Jul 11, 2017
gianm pushed a commit to gianm/druid that referenced this pull request Jul 11, 2017
b-slim added a commit to b-slim/druid that referenced this pull request Jul 11, 2017
fjy pushed a commit that referenced this pull request Jul 11, 2017
@b-slim b-slim deleted the fix_compile_scope branch April 26, 2018 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants