Skip to content

Default implementation for getDouble(). #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjain1 merged 4 commits into from
Jul 26, 2017
Merged

Default implementation for getDouble(). #4595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f58b56f
Default implementation for getDouble().
akashdw Jul 24, 2017
75d6b50
use getFloat for default implementation.
akashdw Jul 25, 2017
e473636
addressed comment.
akashdw Jul 25, 2017
d0f7d9a
new line.
akashdw Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion processing/src/main/java/io/druid/query/aggregation/Aggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,16 @@ public interface Aggregator extends Closeable
Object get();
float getFloat();
long getLong();
double getDouble();

/**
* The default implementation casts {@link Aggregator#getFloat()} to double.
* This default method is added to enable smooth backward compatibility, please re-implement it if your aggregators
* work with numeric double columns.
*/
default double getDouble()
{
return (double) getFloat();
}

@Override
void close();
Expand Down
9 changes: 8 additions & 1 deletion processing/src/main/java/io/druid/query/aggregation/BufferAggregator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,18 @@ public interface BufferAggregator extends HotLoopCallee
* have an {@link AggregatorFactory#getTypeName()} of "double".
* If unimplemented, throwing an {@link UnsupportedOperationException} is common and recommended.
*
* The default implementation casts {@link BufferAggregator#getFloat(ByteBuffer, int)} to double.
* This default method is added to enable smooth backward compatibility, please re-implement it if your aggregators
* work with numeric double columns.
*
* @param buf byte buffer storing the byte array representation of the aggregate
* @param position offset within the byte buffer at which the aggregate value is stored
* @return the double representation of the aggregate
*/
double getDouble(ByteBuffer buf, int position);
default double getDouble(ByteBuffer buf, int position)
{
return (double) getFloat(buf, position);
}

/**
* Release any resources used by the aggregator
Expand Down