Fix a NPE using kafka emitter extension#4608
Merged
jihoonson merged 3 commits intoapache:masterfrom Aug 8, 2017
Merged
Conversation
Contributor
|
@wywlds thanks can you please fill the CLA http://druid.io/community/cla.html |
Contributor
Author
|
@b-slim Hi, I already filled the form when I created a pull-request last weekend. |
Contributor
|
👍 |
leventov
approved these changes
Jul 29, 2017
leventov
reviewed
Jul 29, 2017
| this.alertTopic = Preconditions.checkNotNull(alertTopic, "alert.topic can not be null"); | ||
| this.clusterName = clusterName; | ||
| this.kafkaProducerConfig = kafkaProducerConfig; | ||
| this.kafkaProducerConfig = kafkaProducerConfig == null? ImmutableMap.<String,String>of() : kafkaProducerConfig; |
Member
There was a problem hiding this comment.
Please annotate kafkaProducerConfig parameter as @Nullable
Contributor
Author
There was a problem hiding this comment.
@leventov Thank you for the review, I added @Nullable in the latest commit.
jihoonson
approved these changes
Aug 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this exception when using kafka emitter according to doc kafka-emitter.
It said "druid.emitter.kafka.producer.config" is not required, so I didn't set it. As a result I got an NPE exception when starting up my overlord.