update internal-discovery Listener for node list and use same at router and coordinator#4697
Merged
cheddar merged 15 commits intoapache:masterfrom Aug 25, 2017
Merged
Conversation
himanshug
force-pushed
the
membership_pr1_2
branch
4 times, most recently
from
0059220 to
f796e44
Compare
Contributor
|
Could we switch the API to use lists of nodes instead of individual and have the contract be that the first initialization is actually given the full list? |
himanshug
changed the title
…callback initialization asynchronously
…segment callback initialization asynchronously" This reverts commit f796e441221fe8b0e9df87fdec6c9f47bcedd890.
This reverts commit f0661541d073683f28fce2dd4f30ec37db90deb0.
…d first call marks initialization
himanshug
force-pushed
the
membership_pr1_2
branch
from
a8a88e7 to
b718d28
Compare
Contributor
|
👍 |
leventov
reviewed
Nov 11, 2018
| for (Listener listener : listeners) { | ||
| listener.nodeRemoved(node); | ||
| synchronized (lock) { | ||
| if (uninitializedNodeTypeListeners.isEmpty()) { |
Member
There was a problem hiding this comment.
@himanshug could you explain what does this mean? The logic around uninitializedNodeTypeListeners is super convoluted. And it doesn't seem to work for Listeners that are not NodeTypeListener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4634
This patch