Closed
Conversation
Contributor
|
👍 |
Contributor
|
@niketh is this still an issue that is solved by this PR? |
Contributor
Author
|
@b-slim @drcrallen I realized that we already that the JettyServerModule already had a handle to the hum of open connections. In this PR I take advantage of that variable to have better handling on shutdown #4716 . Can you review ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We see queries failing while realtime handoff is happening mainly because Jetty is not being shutdown gracefully. Here is the error
Failure getting results from[http://host:port/druid/v2/] because of [org.jboss.netty.channel.ChannelException: Channel disconnectedThe solution is to a graceful shutdown in the jetty server. This will also reduce failed queries on shutdown on the broker and historical also.