Update emitter library and add support for ParametrizedUriEmitter#4722
Merged
leventov merged 8 commits intoapache:masterfrom Sep 13, 2017
Merged
Update emitter library and add support for ParametrizedUriEmitter#4722leventov merged 8 commits intoapache:masterfrom
leventov merged 8 commits intoapache:masterfrom
Conversation
….druid.server.emitter package; Update emitter library to 0.6.0; Add support for ParametrizedUriEmitter; Support hierarical properties in JsonConfigurator (was needed for ParametrizedUriEmitter)
himanshug
requested changes
Sep 12, 2017
|
|
||
| final Emitter emitter = | ||
| makeInjectorWithProperties(props).getInstance(Emitter.class); | ||
| System.out.println(emitter); |
Contributor
There was a problem hiding this comment.
is this left by mistake ?
| } | ||
| String nestedKey = property.substring(0, dotIndex); | ||
| Object nested = targetMap.computeIfAbsent(nestedKey, k -> new HashMap<String, Object>()); | ||
| if (!(nested instanceof Map)) { |
Contributor
There was a problem hiding this comment.
given that targetMap passed is a method local object, why can't we simple do it like...
if (targetMap.containsKey(nestedKey)) {
..
} else {
..
}
Member
Author
There was a problem hiding this comment.
The value may be a Map or a String, !(nested instanceof Map) checks that the nested map couldn't be populated
himanshug
approved these changes
Sep 12, 2017
Member
Author
|
@himanshug could you please merge? |
drcrallen
reviewed
Sep 13, 2017
| |`druid.emitter.http.flushMillis`|How often the internal message buffer is flushed (data is sent).|60000| | ||
| |`druid.emitter.http.flushCount`|How many messages the internal message buffer can hold before flushing (sending).|500| | ||
| |`druid.emitter.http.recipientBaseUrl`|The base URL to emit messages to. Druid will POST JSON to be consumed at the HTTP endpoint specified by this property.|none| | ||
| |`druid.emitter.http.basicAuthentication`|Login and password for authentification in "login:password" form, e. g. `druid.emitter.http.basicAuthentication=admin:adminpassword`|not specified = no authentification| |
Contributor
There was a problem hiding this comment.
wish list: this to be a PasswordProvider
drcrallen
reviewed
Sep 13, 2017
| { | ||
| return new LoggingRequestLogger(mapper, setMDC, setContextMDC); | ||
| LoggingRequestLogger logger = new LoggingRequestLogger(mapper, setMDC, setContextMDC); | ||
| log.info(new Exception("Stack trace"), "Creating %s at", logger); |
Contributor
There was a problem hiding this comment.
should these be debug level?
Contributor
|
@leventov feel free to self merge when you're done. |
nishantmonu51
added a commit
to nishantmonu51/druid
that referenced
this pull request
Jan 1, 2018
This was a regression introduced in apache#4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names
jon-wei
pushed a commit
that referenced
this pull request
Jan 3, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in #4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Jan 3, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in apache#4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
jon-wei
added a commit
that referenced
this pull request
Jan 4, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in #4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
gianm
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in #4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emitterlibrary from 0.4.5 to 0.6.0io.druid.server.initializationto the dedicated packageParametrizedUriEmitter(introduced in emitter 0.5.0)JsonConfigurator(was needed forParametrizedUriEmitterconfigs)RequestLoggers, for some debugging/operations visibility.