Use internal-discovery and http for talking to overlord/coordinator leaders#4735
Merged
cheddar merged 5 commits intoapache:masterfrom Sep 11, 2017
Merged
Use internal-discovery and http for talking to overlord/coordinator leaders#4735cheddar merged 5 commits intoapache:masterfrom
cheddar merged 5 commits intoapache:masterfrom
Conversation
himanshug
force-pushed
the
membership_pr2_2
branch
2 times, most recently
from
61d8e3e to
02dedff
Compare
himanshug
force-pushed
the
membership_pr2_2
branch
2 times, most recently
from
88ea4b0 to
3046c40
Compare
himanshug
changed the title
himanshug
force-pushed
the
membership_pr2_2
branch
2 times, most recently
from
510e616 to
f1a2432
Compare
himanshug
changed the title
…ache initialization
…hen needed so that DruidNodeDiscovery impl cache gets initialized well in time
…covery when needed so that DruidNodeDiscovery impl cache gets initialized well in time" This reverts commit f1a2432614ba56ddc2d55fe47e990d17fcfd6129.
…very so that it has its cache update well in time
himanshug
force-pushed
the
membership_pr2_2
branch
from
833e6f2 to
6f1b702
Compare
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces class
DruidLeaderClientto facilitate interaction with coordinator and overlord leaders. Please see the javadoc on class for more information.Above class is intended to discover all coordinator or overlord nodes from internal discovery and then interact with the leader by depending upon the existing redirection feature and getLeader endpoint provided by them.
However, to retain backward compatibility and to allow rolling upgrade, it first tries to find the coordinator or overlord node in external discovery which shall be removed in future.
All the other classes that used to interact with coordinator or overlord leaders have been updated to use
DruidLeaderClient.