Skip to content

Expose version property for CustomVersioningPolicy#4747

Merged
gianm merged 1 commit intoapache:masterfrom
kevinconaway:fix-cv
Sep 3, 2017
Merged

Expose version property for CustomVersioningPolicy#4747
gianm merged 1 commit intoapache:masterfrom
kevinconaway:fix-cv

Conversation

@kevinconaway
Copy link
Copy Markdown
Contributor

This allows the CustomVersioningPolicy to serialize and deserialize properly.

Otherwise when you submit a task that uses it, the version is lost when it is saved to, and then read out of, metadata storage

…erialize/deserialize correctly

Expose version property for  so that it may serialize/deserialize correctly

Expose version property for `CustomVersioningPolicy` so that it may serialize/deserialize correctly

Expose version property for CustomVersioningPolicy so that it may serialize/deserialize correctly

Expose version property for `CustomVersioningPolicy` so that it may serialize/deserialize correctly
@kevinconaway
Copy link
Copy Markdown
Contributor Author

kevinconaway commented Sep 3, 2017

The CuratorDruidLeaderSelectorTest from #4699 test seems fail intermittently. I see it failing on another PR as well: https://travis-ci.org/druid-io/druid/jobs/271134762

@jihoonson
Copy link
Copy Markdown
Contributor

I restarted the failed job.

Copy link
Copy Markdown
Member

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gianm gianm added this to the 0.11.0 milestone Sep 3, 2017
@gianm gianm added the Bug label Sep 3, 2017
@gianm gianm merged commit 83e94e8 into apache:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants