Replace HistoricalFloatColumnSelector with more generic HistoricalColumnSelector#4796
Merged
drcrallen merged 1 commit intoapache:masterfrom Sep 14, 2017
Merged
Conversation
Member
Author
|
This bug was found when I was preparing another patch around ColumnValueSelectors, and those places has started to be caught by Java type system. So that other patch doesn't compile without this one merged. That is why marked as |
gianm
approved these changes
Sep 14, 2017
drcrallen
reviewed
Sep 14, 2017
|
|
||
| default LongColumnSelector makeLongColumnSelector(ReadableOffset offset) | ||
| { | ||
| return new LongColumnSelector() |
Contributor
There was a problem hiding this comment.
I'm not familiar with java semantics for this part. Will this create a new class in a way different than an anonymous class since the class def is inline?
Contributor
There was a problem hiding this comment.
https://docs.oracle.com/javase/tutorial/java/javaOO/anonymousclasses.html seems to indicate they should behave the same way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #4491, this: https://github.com/druid-io/druid/blob/aa7e4ae5e46a13a9db8d0ee29885249fd0afd02e/processing/src/main/java/io/druid/query/topn/PooledTopNAlgorithm.java#L134 and this: https://github.com/druid-io/druid/blob/aa7e4ae5e46a13a9db8d0ee29885249fd0afd02e/processing/src/main/java/io/druid/query/topn/PooledTopNAlgorithm.java#L155 conditions could never be true.