Add ObjectColumnSelector's methods to ColumnValueSelector interface#4801
Merged
himanshug merged 1 commit intoapache:masterfrom Sep 19, 2017
Merged
Conversation
…classOfObject() to ColumnValueSelector
drcrallen
approved these changes
Sep 18, 2017
Contributor
drcrallen
left a comment
drcrallen
left a comment
There was a problem hiding this comment.
Mostly semantic or type safety changes. Looks good!
drcrallen
reviewed
Sep 18, 2017
| * @see ObjectAggregateCombiner | ||
| */ | ||
| public interface AggregateCombiner extends ColumnValueSelector | ||
| public interface AggregateCombiner<T> extends ColumnValueSelector<T> |
Contributor
There was a problem hiding this comment.
Will this cause extensions to need to be modified? or will extensions that include AggregateCombiner implementations still work the same?
Member
Author
There was a problem hiding this comment.
AggregateCombiner is added just recently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectValueSelector.get()togetObject()getObject()andclassOfObject()toColumnValueSelectorFollow-up of #4623. Later when doing #4622, I realised that "object" methods are also needed in the root interface.
This PR is also a foundation for #4800.